modin-project / modin

Modin: Scale your Pandas workflows by changing a single line of code
http://modin.readthedocs.io
Apache License 2.0
9.85k stars 651 forks source link

Pandas `read_gbq` unable to process `progress_bar_type` kwarg #1398

Closed yxue-kabam closed 4 years ago

yxue-kabam commented 4 years ago

System information

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/app/modin-project-modin-05754d9/modin/pandas/io.py", line 186, in read_gbq
    return DataFrame(query_compiler=BaseFactory.read_gbq(**kwargs))
  File "/app/modin-project-modin-05754d9/modin/data_management/factories.py", line 81, in read_gbq
    return cls._determine_engine()._read_gbq(**kwargs)
  File "/app/modin-project-modin-05754d9/modin/data_management/factories.py", line 87, in _read_gbq
    return cls.io_cls.read_gbq(**kwargs)
TypeError: read_gbq() got an unexpected keyword argument 'progress_bar_type'

calling help(PandasOnRayIO.read_gbq) shows the following signature

read_gbq(query, project_id=None, index_col=None, col_order=None, reauth=False, auth_local_webserver=False, dialect=None, location=None, configuration=None, credentials=None, private_key=None, verbose=None)

which misses support for progress_bar_type while current pandas read_gbq expects that.

Source code / logs

https://github.com/modin-project/modin/blob/05754d98d95cef53654a8aeee112cf986519654d/modin/pandas/io.py#L165

devin-petersohn commented 4 years ago

Thanks @yxue-kabam for the report!

Testing locally, there is another missing keyword from the internal API: use_bqstorage_api.