Make FileReader.read more general than current implementation for pandas kernels

modin-project / modin

Modin: Scale your Pandas workflows by changing a single line of code

http://modin.readthedocs.io

Apache License 2.0

9.88k stars 651 forks source link

Make FileReader.read more general than current implementation for pandas kernels #1504

Open gshimansky opened 4 years ago

gshimansky commented 4 years ago

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

All

Modin version (modin.__version__):

0.7.3+57.g23015c5

Python version:

Python 3.8.2

Code we can use to reproduce:

Code in PR #1382 for FileReader.read works only for pandas partitions. It should be generalized.

Describe the problem

Source code / logs

aregm commented 4 years ago

@gshimansky Can you please provide more information and context about this issue? It is not clear what was the problem and whether it is resolved or not?

devin-petersohn commented 3 years ago

@gshimansky What is the exact issue in this case? Are there lines of code that cause issues for other types of readers?

gshimansky commented 3 years ago

@devin-petersohn This issue was opened according to your comment https://github.com/modin-project/modin/pull/1382/files#r432030895 in PR #1382 . If you think this is no longer relevant, feel free to close this issue.

pyrito commented 2 years ago

I see that the TODO is still there, so I'm going to move this from bug to a code quality issue.