modin-project / modin

Modin: Scale your Pandas workflows by changing a single line of code
http://modin.readthedocs.io
Apache License 2.0
9.9k stars 653 forks source link

Unpack `**kwargs` that hiding actual parameters for the Query Compiler methods #3108

Open dchigarev opened 3 years ago

dchigarev commented 3 years ago

Many of the BaseQueryCompiler methods are hiding actual arguments by using *args and **kwargs instead of them. They should be spread into actual parameters.

Example of function hiding parameters: https://github.com/modin-project/modin/blob/a3ddf2f01163a312416d2a8bc456ba9582ae9b4d/modin/backends/base/query_compiler.py#L544-L550 BaseQueryCompiler.count method takes **kwargs instead of actual parameters that are passed from the front-end: https://github.com/modin-project/modin/blob/a3ddf2f01163a312416d2a8bc456ba9582ae9b4d/modin/pandas/base.py#L970-L972

RehanSD commented 2 years ago

@dchigarev has this issue been resolved? I checked the BaseQueryCompiler and it seems like this is still happening, so should we assign someone to this?

mvashishtha commented 2 years ago

@RehanSD we still do this in many query compiler functions at Modin version 88f7b27d32b099c508e93251cafe503f2908d426.

dchigarev commented 2 years ago

@RehanSD yes, it's still relevant. As @mvashishtha noticed there are still numerous of qc methods that still follow this **kwargs pattern. However, the issue is not critical at all and thus should be low prioritized.

so should we assign someone to this?

This could be a "good first issue" for a new-comers, however, as I believe we have more prioritized tasks now, so I would prefer to focus on them, but not on the very low-prioritized ones.