modin-project / modin

Modin: Scale your Pandas workflows by changing a single line of code
http://modin.readthedocs.io
Apache License 2.0
9.85k stars 651 forks source link

`df_equals` testing util does not check that dtypes are equal #3804

Open RehanSD opened 2 years ago

RehanSD commented 2 years ago

System information

Describe the problem

The df_equals testing utility which compares two dataframes to ensure equality does not check dtypes - allowing cases like the following to succeed, when they should error out:

>>> pandas_df
   A  B
0  1  2
1  3  4
>>> modin_df
     A    B
0  1.0  2.0
1  3.0  4.0
>>> df_equals(modin_df, pandas_df)
# Should raise assertion error, but passes instead

Epic

This issue is an epic, here are actual tasks:

devin-petersohn commented 2 years ago

@Garra1980 I think this needs to be high priority. We will need a lot of efforts to correct some of these.

Garra1980 commented 2 years ago

@devin-petersohn agree, let's try to cleanup everything in the upcoming release

Garra1980 commented 2 years ago

we can create or convert this issue into epic and track all problems there

devin-petersohn commented 2 years ago

Let's make this an epic