modio / modio-sdk-legacy

SDK for integrating mod.io into your game - a modding API for game developers
https://sdk.mod.io
MIT License
81 stars 27 forks source link

Don't override CMAKE_BUILD_TYPE setting #100

Closed SupSuper closed 5 years ago

SupSuper commented 5 years ago

Explicitly setting CMAKE_BUILD_TYPE overrides any option the user might set. Instead let's check if it's set first, effectively making it a default.

While Release is a nice default for production, we still wanna be able to build other configurations so we can use Debug builds with Debug programs (in C++ all libs and programs must have the same configuration or nasty crashes will happen).

Turupawn commented 5 years ago

Awesome! :+1: