Do not apply proxy settings automatically

moditect / layrry

A Runner and API for Layered Java Applications

Apache License 2.0

332 stars 33 forks source link

Do not apply proxy settings automatically #88

Closed aalmiray closed 3 years ago

aalmiray commented 3 years ago

Proxy settings should be applied if an only if a proxy is needed. Current code (1.0.0.Alpha1) fails when no proxy is required yet one is applied to the HttpClient.

gunnarmorling commented 3 years ago

@aalmiray, added this and #87 to a new milestone, 1.0.0.Beta1. I think it makes sense to start tracking items like that now that the first release went out.

gunnarmorling commented 3 years ago

Also, as a good measure, let's try and have an issue that can be referenced for each (substantial) commit. No need for that for typo fixes etc. I put the PR from @joschi into that milestone too, as there was no issue for it. Let's usually avoid that though and only track issues in milestones.

github-actions[bot] commented 1 year ago

Released in v1.0.0.Alpha2 -> https://github.com/moditect/layrry/releases/tag/v1.0.0.Alpha2