search

moditect / oss-quickstart

Apache Maven artifacts for bootstrapping new open-source projects
Apache License 2.0
63 stars 5 forks source link

Use package-private for Jupiter tests #25

Closed LorenzoBettini closed 1 year ago

LorenzoBettini commented 1 year ago

Jupiter fosters the use of package-private modifiers for test classes and methods (SonarQube also fosters that).

gunnarmorling commented 1 year ago

@LorenzoBettini hum, hum; That's interesting, the test failures kinda indicate this doesn't work that well. Any thoughts?

LorenzoBettini commented 1 year ago

@LorenzoBettini hum, hum; That's interesting, the test failures kinda indicate this doesn't work that well. Any thoughts?

Maybe because of Java modules, which I never used (and for the moment, never will ;)

please feel free to ignore my proposal (however, SonarQube detects that as an issue, maybe it does not consider Java modules). Sorry for the noise, and nice project by the way :)

gunnarmorling commented 1 year ago

Yes, the archetype contains a module descriptor by default. You could of course prevent the issue with --add-opens, but I don't quite see the value of that over simply making the methods public. In that light, I'm going to close this PR. Thanks for your efforts nevertheless!