search

modlinltd / django-advanced-filters

Add advanced filtering abilities to Django admin
https://pypi.org/project/django-advanced-filters/
MIT License
769 stars 172 forks source link

Make SimpleJSON optional #181

Open baseplate-admin opened 1 year ago

baseplate-admin commented 1 year ago

Is your feature request related to a problem? Please describe. Hi there, It Seems that you guys bundle simplejson when installing the project. Is it possible not to do this? Because its yet another dependency when i have orjson, pysimdjson in my project.

Describe the solution you'd like Make SimpleJson optional. Preferably with django-advanced-filters[simplejson]

Describe alternatives you've considered Forking the project and making a downstream patch

Additional context Now that CPython is getting faster chances are we wont need simplejson to make things faster unless i am missing something here

Thanks :D

aqeelat commented 1 year ago

I agree here. I even think simplejson should be removed since the features we need are included in stdlib.