search

modlinltd / django-advanced-filters

Add advanced filtering abilities to Django admin
https://pypi.org/project/django-advanced-filters/
MIT License
769 stars 172 forks source link

Made SimpleJson optional #182

Open baseplate-admin opened 1 year ago

baseplate-admin commented 1 year ago

Closes #181

baseplate-admin commented 1 year ago

Hi, Thanks for your response. I am a bit busy now. Will swing back to this PR soon.

I think we can take it a step further and just remove simplejson entirely now. I say this because it seems we only used simplejson to support python 2.7/3.3, as per their docs:

I also think stdlib's json does make more sense to support.

Before we apply merge the change, though, could we add a test case or two to advanced_filters/tests/test_q_serializer.py which ensure serialising and unserialising date and datetime values work?

Sure gimme some time

baseplate-admin commented 2 months ago

Hi, sorry i forgot about this PR.

https://github.com/modlinltd/django-advanced-filters/pull/182#pullrequestreview-1425894485 has been addressed. Please take a look.