search

modlinltd / django-advanced-filters

Add advanced filtering abilities to Django admin
https://pypi.org/project/django-advanced-filters/
MIT License
771 stars 173 forks source link

should use latest updated Requirements ex. django-easy-select2==1.3.3 #33

Closed sanchig closed 7 years ago

sanchig commented 8 years ago

we are using latest django-easy-select2 and simplejson for our project requirement. but when we are try to install django-advanced-filters this will start to auto download old versions of Requirements. I think you should use latest version of all Requirements. We are using this command to install (for ref.) pip install django-advanced-filters

asfaltboy commented 8 years ago

Hi @sanchig , thank you for your bug report!

In general I'm all in favor of using newest versions of dependencies; however, we need to make sure these newer versions don't break current functionality. Our current requirenetns are:

'django-easy-select2==1.2.5',
'django-braces==1.4.0',
'simplejson>=3.6.5',

Simplejson doesn't seem to be breaking anything, so we could bump and soft freeze >=3.8.2. And django-braces also seems fine.

As for django-easy-select2, version 1.3 removes deprecated Select2TextInput() which is imported in advanced_filters/form_helpers.py. I had a quick look and it seems it can be replaced with the Select2() object but the update of the javascript library select2 to version >4 disables input of user defined choice, and I couldn't find an easy way to enable it back.

As always, PR is appreceiated.

asfaltboy commented 7 years ago

As reported in issue #34, upgrading (or replacing) django-easy-select is a requirement to add support for Django 1.10.

asfaltboy commented 7 years ago

Ha, silly me! I grepped the code and we don't even use any functionality of django-easy-select2! This basically means that we can include the js/css manually and remove this dependency entirely!

asfaltboy commented 7 years ago

PR #36 makes this a non-issue, 1.0.5 will be release shortly