modlinltd / django-advanced-filters

Add advanced filtering abilities to Django admin
https://pypi.org/project/django-advanced-filters/
MIT License
771 stars 173 forks source link

select2 undefined on query-value #5

Closed agix closed 9 years ago

agix commented 9 years ago

Javascript crash on https://github.com/modlinltd/django-advanced-filters/blob/master/advanced_filters/static/advanced-filters/advanced-filters.js#L140

removing this line fix the issue as query-value is not a select form and select2 seems to work only on select form.

I have no idea if it's intended

asfaltboy commented 9 years ago

I believe this is intended, can't really recall what for, probably cleanup. I do believe select2 replaces the select field into a bunch of elements (and input is one of them), and they all have the "select2" object attached to them. In other words, this works for me.

Does select2 works well for you everywhere else, such as in initialize_select2? The same call to destroy is made here too, as well as the init.

Please add some details on your scenario, step by step actions, etc.

agix commented 9 years ago

It crashes on initialize_select2 too.

Step by step I clone the repo, setup.py install it, migrate, add the settings, add the static files, and add AdminAdvancedFiltersMixin to my admin class.

Really nothing special I think...

I think the query-value may be transformed somewhere in a select list of choices but I don't find where or how.

asfaltboy commented 9 years ago

Thanks for the report, I'll attempt to reproduce and get back to you.

eriktelepovsky commented 2 years ago

Issue still exists in current version 1.3.0.

Django==3.1.12 Python 3.9.8

asfaltboy commented 2 years ago

5 years later the above issue was resolved, I can't help but wonder if this is possibly a different issue 🤔

@eriktelepovsky kindly file a separate bug ticket with the details above as well as a traceback; from python logs, or javascript browser console, and any other information you feel relevant 🙏