search

modlinltd / django-advanced-filters

Add advanced filtering abilities to Django admin
https://pypi.org/project/django-advanced-filters/
MIT License
771 stars 173 forks source link

BUGFIX - do not replace values in edit view #77

Closed mrname closed 6 years ago

mrname commented 6 years ago

When editing a pre-existing advanced filter object, the javascript is overwriting pre-existing values with a blank select 2 box like so:

select2_bug

The fix implemented here modifies the behavior like so:

select2_fixed

Note that I am not much of a JS dev, so not sure this is the best way to handle the issue.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 96.06% when pulling f1c1f5e36cedb7f0ce72aa37d5961218711e532e on mrname:detail_view_select2_fix into c88bafcb4028f80efac4b1aa11a02fe7906076e9 on modlinltd:develop.

mrname commented 6 years ago

Actually, it looks like this PR handles the issue in a better way:

https://github.com/modlinltd/django-advanced-filters/pull/31

However, it has not made movement in about 2 years. Is there something that still needs to be done there that I could assist with?

asfaltboy commented 6 years ago

Thanks @mrname , would you mind testing PR #31 out and giving you feedback on it there?

mrname commented 6 years ago

Sounds good @asfaltboy I will go ahead and close this PR in the meantime as well.