modlinltd / django-advanced-filters

Add advanced filtering abilities to Django admin
https://pypi.org/project/django-advanced-filters/
MIT License
771 stars 173 forks source link

exception migrating with oracle backend #78

Closed enricofer closed 4 years ago

enricofer commented 6 years ago

I get this exception migrating with oracle backend (Django==1.11.13 cx-Oracle==6.3.1)

Applying advanced_filters.0001_initial...Traceback (most recent call last): File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/utils.py", line 62, in execute return self.cursor.execute(sql) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/oracle/base.py", line 497, in execute return self.cursor.execute(query, self._param_generator(params)) cx_Oracle.DatabaseError: ORA-00910: specified length too long for its datatype

The above exception was the direct cause of the following exception:

Traceback (most recent call last): File "manage.py", line 22, in execute_from_command_line(sys.argv) File "/home/urb/.ia/lib/python3.4/site-packages/django/core/management/init.py", line 364, in execute_from_command_line utility.execute() File "/home/urb/.ia/lib/python3.4/site-packages/django/core/management/init.py", line 356, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/home/urb/.ia/lib/python3.4/site-packages/django/core/management/base.py", line 283, in run_from_argv self.execute(*args, *cmd_options) File "/home/urb/.ia/lib/python3.4/site-packages/django/core/management/base.py", line 330, in execute output = self.handle(args, **options) File "/home/urb/.ia/lib/python3.4/site-packages/django/core/management/commands/migrate.py", line 204, in handle fake_initial=fake_initial, File "/home/urb/.ia/lib/python3.4/site-packages/django/db/migrations/executor.py", line 115, in migrate state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/migrations/executor.py", line 145, in _migrate_all_forwards state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/migrations/executor.py", line 244, in apply_migration state = migration.apply(state, schema_editor) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/migrations/migration.py", line 129, in apply operation.database_forwards(self.app_label, schema_editor, old_state, project_state) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/migrations/operations/models.py", line 97, in database_forwards schema_editor.create_model(model) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/base/schema.py", line 319, in create_model self.execute(sql, params or None) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/base/schema.py", line 136, in execute cursor.execute(sql, params) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/utils.py", line 79, in execute return super(CursorDebugWrapper, self).execute(sql, params) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/utils.py", line 64, in execute return self.cursor.execute(sql, params) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/utils.py", line 94, in exit six.reraise(dj_exc_type, dj_exc_value, traceback) File "/home/urb/.ia/lib/python3.4/site-packages/django/utils/six.py", line 685, in reraise raise value.with_traceback(tb) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/utils.py", line 62, in execute return self.cursor.execute(sql) File "/home/urb/.ia/lib/python3.4/site-packages/django/db/backends/oracle/base.py", line 497, in execute return self.cursor.execute(query, self._param_generator(params)) django.db.utils.DatabaseError: ORA-00910: specified length too long for its datatype

asfaltboy commented 5 years ago

Our b64_query = models.CharField(max_length=2048) might be causing this, a bit of googling reveals that Oracle < 12c does not allow storing more than 2k characters in a CHAR field.

You might be able to work around this meanwhile, by subclassing the AdvancedFilter model and making the b64_query field into Django models.TextField. Let us know how it goes, and please feel free to submit a PR 👍