search

modm-io / modm

modm: a C++23 library generator for AVR and ARM Cortex-M devices
https://modm.io
Mozilla Public License 2.0
747 stars 132 forks source link

vscode json generation #1072

Open thestumbler opened 1 year ago

thestumbler commented 1 year ago

I noticed a few quirks with the VSCode JSON files generated in the .vscode directory using the build build -m ::vscode command as described here.

(1) Using these JSON scripts, VSCode reports a deprecated entry:

WAS:   "runToMain": true
IS:    "runToEntryPoint": "main"

(2) The script generating these JSON files is generating them as JSONC (JSON with comments). Looks like VSCode doesn't have any problem reading it, but my editor NEOVIM was a sea of bright red denoting the JSON "errors"

(3) Documentation search oddness... if you search for VSCODE, there are two results. But if you search for "VISUAL STUDIO CODE", only one result (the page about using VSCode along with WSL2 is missing).

VSCode isn't something I'll use very often, but the debugger integration is very good. Much better than I expected.

salkinium commented 1 year ago

I think that code generation module is a little out-of-date by now, we should upgrade it.

thestumbler commented 1 year ago

One more small thing I noticed yesterday. The very last line (just a right curly bracket) of the automatically generated files doesn't have a newline. It didn't cause any problems that I'm aware of. But the JSON specification may have something to say about that.