[ext] Check for device.hpp before including in CMSIS-DSP

modm-io / modm

modm: a C++23 library generator for AVR and ARM Cortex-M devices

https://modm.io

Mozilla Public License 2.0

748 stars 132 forks source link

[ext] Check for device.hpp before including in CMSIS-DSP #1203

Open calebchalmers opened 1 month ago

calebchalmers commented 1 month ago

Checks for the existence of modm/platform/device.hpp before including it in arm_math.h. This fixes CMSIS-DSP not compiling when running on a hosted platform (#1201).

salkinium commented 1 month ago

Could you add an example for Linux using CMSIS-DSP? Otherwise future refactoring will break this again.

calebchalmers commented 1 month ago

Okay so after trying to add an example for this, I realized that the CMSIS DSP module isn't even available when using hosted-linux... So something seems wrong on our project's end, since it's including those DSP headers somehow.

salkinium commented 1 month ago

Any update on this? I still find this a valuable idea!

calebchalmers commented 3 weeks ago

I've been busy with classes lately, so I haven't had a chance to dig through our project to find what was causing this issue yet :(

If you want this to be added anyway, we would also have to also allow the DSP module to be used in hosted environments. Removing the check for that shouldn't be hard, but idk if it would simply work or require more effort?