search

modm-io / modm

modm: a C++23 library generator for AVR and ARM Cortex-M devices
https://modm.io
Mozilla Public License 2.0
738 stars 132 forks source link

Rewrite modm:ui:graphic #660

Closed TomSaw closed 2 years ago

TomSaw commented 3 years ago

Changed some lines of the Display-API to make graphics appear faster by a factor.

PR containing the whole, latest codebase for reference: #665

Here's a little preview, running on STM32F0 @48Mhz

https://user-images.githubusercontent.com/738535/125512287-f0789d28-b91d-4732-8b4b-c6905b9cad61.mp4

The Number is rendered into a single monochrome Buffer witch is then streamed to different displays. Only the area of the Buffer is affected. Notice the noizy bottom half of the OLEDs. The flickering squares on the ILI9341 comes from debugging code. Soo yes, just a preview ;) Details about the implementation, the benefits and more examples coming soon.

TomSaw commented 3 years ago

Found another promising library not yet mentioned in modms GUI-Issues nor uPainter-Docs. It also builds up on DMA2D and the docs contain some good introduction to graphics on MCUs under Basic-Concepts

TouchGFX

rleh commented 3 years ago

If I remember correctly the TouchGFX license does not allow usage on non-ST devices and/or has expensive fees if used in commercial applications.

chris-durand commented 3 years ago

If I remember correctly the TouchGFX license does not allow usage on non-ST devices and/or has expensive fees if used in commercial applications.

It's free even for commercial applications but the license only permits use with devices manufactured by ST.

TomSaw commented 3 years ago

Ok, at least it's a good resource. Their explanations are very nice to read.

TomSaw commented 3 years ago

Finally, my Workspace 🧮 and Neurons 🧠 are ready to get known to uPainter 🎨

Questions @salkinium:

TomSaw commented 3 years ago

First sub-PR for ILI9341 is out: #664 I've also PR-ed the whole code for reference #665 👉 Please correct me if there's a better practice for my situation of contributing this huge thing in chunks.

salkinium commented 3 years ago

What's the current solution for fixed-point-arithmetics if there's any? CMSIS?

There is none. There's a fixed point class in uPainter, however, it's a little outdated and not as flexible. This seems to be the most promising: https://github.com/MikeLankamp/fpm

Please correct me if there's a better practice for my situation of contributing this huge thing in chunks.

Just make one big PR and partition your changes into separate commits, since we can review the changes by commits instead of by files too (see the tab Commits).

TomSaw commented 3 years ago

Just make one big PR and partition your changes into separate commits, since we can review the changes by commits instead of by files too (see the tab Commits).

So then all changes will be in one branch ? Makes it difficult to evolve the single changes, doesn't it?

salkinium commented 3 years ago

So then all changes will be in one branch? Makes it difficult to evolve the single changes, doesn't it?

Yes, you group them by commits and use fixup commits and interactive rebase to apply patches on you branch. This is a very typical git workflow and helps you break down large order-dependent changes.

You can even collaborate like this, if you carefully synchronize the rebase and force-pushes. We've done this recently for our STM32H7 work.

TomSaw commented 3 years ago

Okay, thanks i'm going to learn and apply this. Please go for review of #665. I'll partition into commits later cause 'some' change requests are expected. It's more efficient doing the partitioning to the end of the workflow !

TomSaw commented 3 years ago

I'm researching a board with DMA2D + Touch-TFT (ILI9341) to get my hands on the serious accelerators.

I could grab a STM32F429 Discovery for small money but can't determine the type of the assemblied Display. Also the appropriate modm:board:disco-f429zi doesn't leave a note.

The're more Disco-boards with backpacked TFTs and weak technical details. How do you source the display-types for STM32-boards?

salkinium commented 3 years ago

According to the User Manual, the F429 Disco has a TFT ILI9341 display. I would however recommend the F469 Disco with a MIPI-DSI panel with capacitive touch, even tough it's expensive (~50€).