modm-io / modm

modm: a C++23 library generator for AVR and ARM Cortex-M devices
https://modm.io
Mozilla Public License 2.0
748 stars 132 forks source link

[driver] Add MAX31865 driver with STM32F469 Discovery example #993

Closed hshose closed 1 year ago

hshose commented 1 year ago
hshose commented 1 year ago

Thanks @salkinium und @rleh for the review.

Please don't merge yet - I havent tested the fixes with hardware yet.

rleh commented 1 year ago

@hshose I pushed some commits to your branch, because it was too confusing to explain this in code comments. Feel free to delete the commits from your branch if you don't like them.

salkinium commented 1 year ago

If it's not too annoying, could you try out your changed on top of #1001 and check if these "weird" issues dissappear?

hshose commented 1 year ago

If it's not too annoying, could you try out your changed on top of #1001 and check if these "weird" issues dissappear?

If I also add the :processing:protothread:use_fiber option it works and fixes #1012. I assume you wanted to mention this under #1012?