modmail-dev / Modmail

A Discord bot that functions as a shared inbox between staff and members, similar to Reddit's Modmail.
https://docs.modmail.dev
GNU Affero General Public License v3.0
1.58k stars 4.6k forks source link

The ability to add permissions on per thread basis #2759

Closed YyAoMmIi closed 4 years ago

YyAoMmIi commented 4 years ago

Is your feature request related to a problem? Please describe. Permission granted is applied to everything on bot. I have 2 level of staff. Main staff and nsfw staff. Main staff have permission level 3. I do not want nsfw staff to access modmail until regular staff give them permission to do so. But giving permission is giving a permanent on bot global level.

Describe the solution you'd like A clear and concise description of what you want to happen. I would like to give permission on a per thread level. So when I use alias [to the short cut [task]], it will give permission on a thread level.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. To just allow the NSFW staff to see all issues.

Who will this benefit Does this feature apply to a great portion of users? This will allow people to have multiple level of staff, and not allow everyone to see modmail at first.

Additional context Add any other context or screenshots about the feature request here. My request in discord: https://discordapp.com/channels/515071617815019520/529240018934431744/664329142212493323

StephenDaDev commented 4 years ago

Hey there! This can be done by just moving the thread using the move command, sorta it will restrict NSFW staff from the main issues, they then can't use the commands in that channel, but they would still be able to use some commands, so you could give all regular staff moderator then override commands to moderator. If you need help with this I'd be happy to help. This would accomplish most of your goal just wouldn't be as easy

YyAoMmIi commented 4 years ago

Problem was I didn't want the nsfw to view the other threads open.

I wanted them to view it after it as moves.

On Wed, Jan 22, 2020, 7:06 PM Stephen notifications@github.com wrote:

Hey there! This can be done by just moving the thread using the move command, sorta it will restrict NSFW staff from the main issues, they then can't use the commands in that channel, but they would still be able to use some commands, so you could give all regular staff moderator then override commands to moderator. If you need help with this I'd be happy to help. This would accomplish most of your goal just wouldn't be as easy

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kyb3r/modmail/issues/2759?email_source=notifications&email_token=AOAKTUZS6VTM2G4OWT2YGYTQ7ECTHA5CNFSM4KEC4WW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJV3MPQ#issuecomment-577484350, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOAKTUYWVVTGPTAO6VZXSZTQ7ECTHANCNFSM4KEC4WWQ .

StephenDaDev commented 4 years ago

You simply don't give them access to the main thread category. Problem solved.

YyAoMmIi commented 4 years ago

That was my initial plan. With task set to move the thread.

Modmail NSFW issue

NSFW staff could not see modmail, and only saw nsfw issue.

However, even when thread moved from modmail to nsfw issues, where nsfw staff could now see, they could not use any modmail commands. Actually, by giving more access to modmail they ended seeing all threads, modmail even the modmail Catagory that they could not initially see

On Fri, Jan 24, 2020, 1:06 PM Stephen notifications@github.com wrote:

You simply don't give them access to the main thread category. Problem solved.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kyb3r/modmail/issues/2759?email_source=notifications&email_token=AOAKTU6T7C54ZBUWJPYN7V3Q7NJ67A5CNFSM4KEC4WW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ4DC6I#issuecomment-578302329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOAKTUZLGMUTNCQNWBMSW5LQ7NJ67ANCNFSM4KEC4WWQ .

StephenDaDev commented 4 years ago

Did you give them permissions with ?permissions add level SUPPORTER [role]

YyAoMmIi commented 4 years ago

Yup, which led to them seeing all modmail threads

On Fri, Jan 24, 2020, 1:24 PM Stephen notifications@github.com wrote:

Did you give them permissions with ?permissions add level SUPPORTER [role]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kyb3r/modmail/issues/2759?email_source=notifications&email_token=AOAKTU3QCRLQYIKECWGJJ4TQ7NMCHA5CNFSM4KEC4WW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ4EO2A#issuecomment-578307944, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOAKTU5MA42WGWOUFBATALDQ7NMCHANCNFSM4KEC4WWQ .

StephenDaDev commented 4 years ago

No. someone along the line changed role and or category permissions. Thats not how the bot works. Are you in our Support Server?

YyAoMmIi commented 4 years ago

Yup

This is when I asked about that function

https://discordapp.com/channels/515071617815019520/529240018934431744/664329142212493323

On Fri, Jan 24, 2020, 1:29 PM Stephen notifications@github.com wrote:

No. someone along the line changed role and or category permissions. Thats not how the bot works. Are you in our Support Server?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kyb3r/modmail/issues/2759?email_source=notifications&email_token=AOAKTU3WFCBO5LTVW53EGP3Q7NMR7A5CNFSM4KEC4WW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ4EYTA#issuecomment-578309196, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOAKTU2DT7JVQQM7WWEFIXDQ7NMR7ANCNFSM4KEC4WWQ .

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 100 days with no activity. Remove stale label or comment or this will be closed in 5 days. Please do not un-stale this issue unless it carries significant contribution.