modmail-dev / Modmail

A Discord bot that functions as a shared inbox between staff and members, similar to Reddit's Modmail.
https://docs.modmail.dev
GNU Affero General Public License v3.0
1.57k stars 4.59k forks source link

Skip check errors #3163

Closed ghost closed 2 years ago

ghost commented 2 years ago

Bot Version

dev14

How are you hosting Modmail?

Other

Error Logs

https://hastebin.cc/gubamibako

Screenshots

The jsk exec command to bypass checks fails. seems like an issue with modmail using it here https://github.com/kyb3r/modmail/blob/77489be6a21cf4befeab1dc7fa2c2d2098104cbc/bot.py#L1102

not sure, didnt have this issue before

Additional Information

No response

Jerrie-Aries commented 2 years ago

Yes. discord.ext.commands.Bot used to have the ._skip_check method and it has been removed. This has been fixed in ModmailBot.get_contexts method with: https://github.com/kyb3r/modmail/blob/77489be6a21cf4befeab1dc7fa2c2d2098104cbc/bot.py#L983 but not in the ModmailBot.get_context (without s).

Maybe create a PR to fix that as well. 😃