search

modmail-dev / Modmail

A Discord bot that functions as a shared inbox between staff and members, similar to Reddit's Modmail.
https://docs.modmail.dev
GNU Affero General Public License v3.0
1.58k stars 4.59k forks source link

Set smaller size for guild icons urls on embed icons #3261

Closed baptiste0928 closed 1 year ago

baptiste0928 commented 1 year ago

The guild icon is used in full size on embed footers or the author icon for some messages. This can cause lag on the mobile app if the icon is animated.

This PR introduces a new optional size argument to get_guild_icon and sets the size to 128 when it's used for embed footers or author icons (I chose a conservative value, 64 should render nicely even on higher DPI).

StephenDaDev commented 1 year ago

You'll want to aim this PR at the development branch and not the main branch

baptiste0928 commented 1 year ago

You'll want to aim this PR at the development branch and not the main branch

Rebased onto development, thanks for noticing.