modmonkey / gtalksms

Automatically exported from code.google.com/p/gtalksms
0 stars 0 forks source link

Allow auto-connection when charger connected and auto-stop when disconnected #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Attaching a patch that adds 2 new preferences - one to allow auto-connection 
when a charger is connected and the other to allow disconnection when not 
charging.  (The version I sent by private mail to Florent didn't have the new 
file - doh!)

Originally requested for TMP in 
http://code.google.com/p/talkmyphone/issues/detail?id=56

Original issue reported on code.google.com by skippy.hammond@gmail.com on 30 Dec 2010 at 12:12

Attachments:

GoogleCodeExporter commented 8 years ago
This is brilliant and perfect! I use this primarily at work, where I have a 
desktop dock, so having it auto-start and stop would be great. (Though I'd like 
to see Tasker integration so I can more finely tune its 
connection/disconnection behavior.)

Original comment by chriscar...@gmail.com on 30 Dec 2010 at 4:45

GoogleCodeExporter commented 8 years ago
Using tasker should be quite possible with a few tweaks - gtalksms now uses 
"startService" calls with regular intents for all operations, including 
connection, disconnection and sending messages - so if taker can arrange to 
send arbitrary intents to a specific service it might even work now!  But I 
don't use tasker, so we probably need someone who does to help us out with some 
more research into this.

Original comment by skippy.hammond@gmail.com on 30 Dec 2010 at 5:22

GoogleCodeExporter commented 8 years ago
There is the ability to send a "component intent" which prompts for a class and 
package name, and has a data and extra field as well. If you tell me the intent 
to send to trigger the connection process, I can try that. (I think I'd have it 
launch the app as a separate step, unless intents work without the app already 
running?)

Original comment by chriscar...@gmail.com on 30 Dec 2010 at 5:52

GoogleCodeExporter commented 8 years ago
if tasker has the ability to target the intent at a specific class, then it 
should work fine - you would use the main service class name.

Otherwise, I think the only intent you can currently send without a class is 
one with an action of ".GTalkSMS.ACTION" (but I *think* you need to prefix that 
with "com.googlecode.gtalksms" - try both :)  That might start the service (or 
if it doesn't, check if it actually started the process).  You should be able 
to do this without the app running - this intent is listed in the manifest, so 
android should know to start us to deliver it.  If that works we could just add 
all our intents to the manifest.

I'm making some of this up though - I'm far from an expert on how some of this 
works :)

Original comment by skippy.hammond@gmail.com on 30 Dec 2010 at 6:14

GoogleCodeExporter commented 8 years ago
Ack - sorry for the spam - I missed that you said it can specify a class.  So 
the class name you want is "com.googlecode.gtalksms.MainService".  Regarding 
intents, you probably want to check the source code to see the intents and any 
possible 'extras' they use - see onHandleIntent in MainService.java.  In theory 
all that should work whether the app is running or not.

Original comment by skippy.hammond@gmail.com on 30 Dec 2010 at 6:16

GoogleCodeExporter commented 8 years ago
I have only the most tenuous of understandings of intents and classes and 
packages... what package do I want if I'm using 
com.googlecode.gtalksms.MainService as my class?

Thanks!

Original comment by chriscar...@gmail.com on 30 Dec 2010 at 6:49

GoogleCodeExporter commented 8 years ago
Not sure, but I guess package is com.googlecode.gtalksms and class is 
MainService.  Maybe we should open a new bug for "tasker integration"?

Original comment by skippy.hammond@gmail.com on 30 Dec 2010 at 6:56

GoogleCodeExporter commented 8 years ago
That's not a bad idea, but I remember the author not liking the idea of 
anything to do with Tasker back when it was TalkMyPhone...

Original comment by chriscar...@gmail.com on 30 Dec 2010 at 7:03

GoogleCodeExporter commented 8 years ago
I'm integrating your patch. I'll will push a new version today if my dev on 
keyboard works.
For tasker, I don't have it but as Skippy says using com.googlecode.gtalksms as 
package with intent ".GTalkSMS.ACTION" should works.

Original comment by Florent....@gmail.com on 30 Dec 2010 at 11:02

GoogleCodeExporter commented 8 years ago

Original comment by Florent....@gmail.com on 30 Dec 2010 at 11:06

GoogleCodeExporter commented 8 years ago
FWIW, I opened http://code.google.com/p/gtalksms/issues/detail?id=18 re tasker.

Original comment by skippy.hammond@gmail.com on 31 Dec 2010 at 5:16

GoogleCodeExporter commented 8 years ago

Original comment by Florent....@gmail.com on 1 Jan 2011 at 9:54

GoogleCodeExporter commented 8 years ago

Original comment by fschm...@gmail.com on 25 Aug 2011 at 7:51