modmonkey / gtalksms

Automatically exported from code.google.com/p/gtalksms
0 stars 0 forks source link

prefix toasts / add collision protection to muc randInt / clears rooms ArrayList after reconnect / moved to asmack #62

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
First the trivial changes:
- Prefix toast messages, so that the user can see where they come from
- Add collision protection to the random number string, if the unlikely case 
ever happens

Then the more tricky ones:
- Clear rooms HashMap: gtalksms does not rejoin the muc rooms on reconnect. If 
a user is in a muc chat with gtalksms, and a reconnect occurs, which is 
followed by a new sms for the muc room, gtalksms would still think the room is 
there and don't recreate it.
- Switched to asmack-issue-13.jar as I hit that issue while debugging the MUC 
code. Simply start gtalksms, be invited to a room, hit the start/stop button 
twice and get "connection failed" errors. See 
http://code.google.com/p/asmack/issues/detail?id=13 for more info. Also asmack 
provides source, which makes it easer to debug xmpp errors.

Finally, I removed a redundant try catch block in createRoom(). Or is there a 
reason to catch an exception, do some logging and throw it again, so that it's 
catched by a another try/catch block that does the same? 

One more try as bundle, this time with a mutual base revision. 

Original issue reported on code.google.com by fschm...@gmail.com on 25 Jan 2011 at 8:41

Attachments:

GoogleCodeExporter commented 8 years ago
I've merge your modifications in the main branch.
I'll will test for a while the new library before making a release.

Original comment by Florent....@gmail.com on 25 Jan 2011 at 10:00

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago

Original comment by Florent....@gmail.com on 29 Jan 2011 at 3:53

GoogleCodeExporter commented 8 years ago
Fixed in v1.8

Original comment by Florent....@gmail.com on 29 Jan 2011 at 10:57

GoogleCodeExporter commented 8 years ago

Original comment by fschm...@gmail.com on 25 Aug 2011 at 7:51