Add black list for shell commands "cmd"

modmonkey / gtalksms

Automatically exported from code.google.com/p/gtalksms

0 stars 0 forks source link

Add black list for shell commands "cmd" #75

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1.send cmd:top
2.send cmt:stop

What is the expected output? What do you see instead?
i was expecting the command top to stop from updating but 
Phone frozen ! Had to reboot by removing the battery !

What version of the product are you using? On what operating system?
last on leedroid 2.3d

Please provide any additional information below.

Original issue reported on code.google.com by yoanjacq...@gmail.com on 4 Feb 2011 at 1:54

GoogleCodeExporter commented 8 years ago

it's a shell command... Stop doesn't exist !
Use "killall top" to kill all top instances 
Or a kill -9 with the PID

Original comment by Florent....@gmail.com on 4 Feb 2011 at 2:01

Changed state: Invalid

GoogleCodeExporter commented 8 years ago

I know this isn't a standard shell command that's why I tried it thinking it 
would stop the top command hence stopping the updates in the messaging window.
Would you try to reproduce this bug to see if the result is the same for you 
before shutting me off ?
Thanks in advance

Ps:by the way i find much easier to use pkill to kill a process no matter what 
its PID is ...

Original comment by yoanjacq...@gmail.com on 4 Feb 2011 at 2:07

GoogleCodeExporter commented 8 years ago

Ok, sorry... 
My phone doesn't freeze.
Let's the bug open if other people have the same issue

Original comment by Florent....@gmail.com on 4 Feb 2011 at 2:22

Changed state: Investigating

GoogleCodeExporter commented 8 years ago

And what is the result of this command on your phone ?
Also, what would be the correct way to stop top from updating ?

Further infos :
Bug reproduced several times with the same result, the last message send by the 
phone is "top killed" 
Same result on the phone when trying the "stop" command with the app terminal 
emulator
This command is not listed in the busybox list of commands

the phone is a Desire running Leedroid 2.3b (and not d like i thought) and 
busybox 1.16.2-leedroid

Maybe a blacklist of commands could be integrated in gtalksms ?

Original comment by yoanjacq...@gmail.com on 4 Feb 2011 at 2:32

GoogleCodeExporter commented 8 years ago

Indeed I don't find any info on the stop command.
It may close the shell interpreter

Original comment by Florent....@gmail.com on 4 Feb 2011 at 2:37

GoogleCodeExporter commented 8 years ago

It seems to be an android issue:
http://groups.google.com/group/android-platform/browse_thread/thread/bd98b8ff2bb
6afc8?pli=1

Original comment by Florent....@gmail.com on 4 Feb 2011 at 2:39

GoogleCodeExporter commented 8 years ago

Indeed, and an unresolved one !

Original comment by yoanjacq...@gmail.com on 4 Feb 2011 at 2:43

GoogleCodeExporter commented 8 years ago

Remove commands "start" and "stop" to avoid Android OS crashes

Original comment by Florent....@gmail.com on 4 Feb 2011 at 3:08

Changed title: _Add black list for shell commands "cmd" _
Changed state: New
Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

"start" and "stop" are standard android developer binaries within the phone 
(/system/bin). See http://developer.android.com/guide/developing/tools/adb.html 
section "Viewing stdout and stderr". They shouldn't be blacklisted, but instead 
used with care. :)

Also I could not reproduce the phone freeze with the stop command on my SGS 
with Android 2.2. On an avd they will stop (freeze) the device.

Original comment by fschm...@gmail.com on 4 Feb 2011 at 3:50

GoogleCodeExporter commented 8 years ago

Original comment by Florent....@gmail.com on 28 Feb 2011 at 8:52

Changed state: Invalid