Bug fix (Receiving SMS - No Reply Contact Set (first SMS)) and new "chat" command

modmonkey / gtalksms

Automatically exported from code.google.com/p/gtalksms

0 stars 0 forks source link

Bug fix (Receiving SMS - No Reply Contact Set (first SMS)) and new "chat" command #84

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Found 2 Bugs:
- lastRecipient is not set, as the commands.containsKey has not the right 
command set. Also Reported in Issue 83
- String rooms in muc implementation has to be lowercase all the way: The user 
could create a muc with a lowercase name but the contacts manager will give us 
a case sensitive name which will result in 2 different rooms for the same 
user/number.

Added "chat" command. Now you can disable creation/invitation to a new MUC room 
upon receiving a new sms and use "chat" to create the room if its really 
needed. Use chat:contact to create a room for a specific contact.

Patch is in my clone: 
http://code.google.com/r/fschmaus-gtalksms/source/detail?r=b2b8107b625b75a289160
976c2a92072ef3af30c

Original issue reported on code.google.com by fschm...@gmail.com on 7 Feb 2011 at 7:00

GoogleCodeExporter commented 8 years ago

Issue 83 has been merged into this issue.

Original comment by fschm...@gmail.com on 7 Feb 2011 at 7:00

GoogleCodeExporter commented 8 years ago

Original comment by fschm...@gmail.com on 7 Feb 2011 at 7:02

Changed title: Bug fix (Receiving SMS - No Reply Contact Set (first SMS)) and new "chat" command

GoogleCodeExporter commented 8 years ago

Nice the chat command :)
Feel free to commit in main branch after your tests.

I'll make a minor release this week for the reply issue

Original comment by Florent....@gmail.com on 7 Feb 2011 at 8:00

GoogleCodeExporter commented 8 years ago

Merged into main repo

Original comment by fschm...@gmail.com on 8 Feb 2011 at 6:20

Changed state: WaitingForRelease

GoogleCodeExporter commented 8 years ago

Issue 101 has been merged into this issue.

Original comment by Florent....@gmail.com on 12 Feb 2011 at 3:56

GoogleCodeExporter commented 8 years ago

Fixed in v1.9.1

Original comment by Florent....@gmail.com on 13 Feb 2011 at 12:48

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

My issue is that when I type in chat:contact name nothing happens...How do I 
add your patch. I use a google sn to connect to a jabber sn...I use imo.im to 
log in.

Original comment by Lore.Tom...@gmail.com on 15 Aug 2011 at 1:59

GoogleCodeExporter commented 8 years ago

The patch is long included, thats why the issue is marked as "fixed". :) For 
support/questions use the gtalksms-users mailing list.

Original comment by fschm...@gmail.com on 15 Aug 2011 at 2:06

GoogleCodeExporter commented 8 years ago

Original comment by fschm...@gmail.com on 25 Aug 2011 at 7:51

Changed state: Deployed