search

modmore / ClientConfig

ClientConfig is a MODX Revolution Extra to allow clients to maintain settings in a user friendly way.
https://docs.modmore.com/en/Open_Source/ClientConfig/index.html
MIT License
28 stars 27 forks source link

Media Source path shown on front end when Image field is left blank #152

Closed withcotton closed 5 years ago

withcotton commented 6 years ago

Summary

Media Source path being included in front end even when no content is included in the config and shows a blank image.

Step to reproduce

– Create a image config with a media source – Leave config blank – add config to template with notempty/not modifier – View site

Observed behavior

Path to media source folder is still show so Config is seen as populated and shows blank image on front end. <img src="path/to/media/source/" />

Expected behavior

Nothing should be shown on the front end if Config is left blank

Environment

ClientConfig v2.0.0-pl, MODX 2.6.5

Mark-H commented 5 years ago

Also reported by Sander via support.

massimiliano-bizen commented 5 years ago

HI @Mark-H - we encountered the same issues, could you update us on this PR?

Maybe we could copy the Magento 2 solutions for the same "problem"? image

Mark-H commented 5 years ago

@massimiliano-bizen I believe the PR in #167 should fix this, but haven't had the time to test it yet. If you can try that and report back on the PR if it resolves the problem for you, then that would be very useful.

Mark-H commented 5 years ago

Fixed in the next release.