search

modmore / ClientConfig

ClientConfig is a MODX Revolution Extra to allow clients to maintain settings in a user friendly way.
https://docs.modmore.com/en/Open_Source/ClientConfig/index.html
MIT License
28 stars 27 forks source link

Finnish translation #161

Closed valokammi closed 5 years ago

valokammi commented 5 years ago

What does it do ?

Finnish language for client config

2.1.0 version clientconfig-fi.zip

sebastian-marinescu commented 5 years ago

Hi @tassu and thank you very much for your translation.

This pull request seems however a little bit confusing, as you somehow added 12 old commits. Your pull request should ideally only add/change the file(s) you want to be changed/added.

So if you have the time, I'd recommend following steps:

  1. Close this PR

  2. Go here (while logged into GitHub): https://github.com/modmore/ClientConfig/tree/master/core/components/clientconfig/lexicon and press "Create new file"

  3. In the text-field at the top-right, enter: "fi/default.inc.php", then in the content-area paste in your translation

  4. Go down to "Propose new file", enter a short title and text and press "propose new file"

  5. I am not sure, but I think you'll afterwards can press "create pull request" and the PR should be perfect then

With best regards, Sebastian