modmore / ClientConfig

ClientConfig is a MODX Revolution Extra to allow clients to maintain settings in a user friendly way.
https://docs.modmore.com/en/Open_Source/ClientConfig/index.html
MIT License
28 stars 27 forks source link

Changing the priority of OnHandleRequest breaks Admin-Area. #165

Closed jdaehne closed 5 years ago

jdaehne commented 5 years ago

Summary

Changing the Priority of the plugin "ClientConfig" event "OnHandleRequest" shows an error in the Admin-Area instead of the user interface. ERROR: Could not find action file at: controllers/default/home.php

Step to reproduce

Change the priority to something else than 0 for the plugin "ClientConfig" event "OnHandleRequest".

Observed behavior

The Admin-Area of ClientConfig shows an error instead of the user interface.

Expected behavior

Show Admin-Area.

Environment

bildschirmfoto 2019-02-28 um 09 42 57

bildschirmfoto 2019-02-28 um 09 40 56

Mark-H commented 5 years ago

I can't reproduce this with the provided steps, and the priority only affects in what order plugins, which fire on the same event, are executed. So if changing the priority is breaking something, I suspect it is because of another plugin also firing on OnHandleRequest.

Right click > update on the event in the plugin's "Events" tab to see what other plugins run.