search

modmore / ClientConfig

ClientConfig is a MODX Revolution Extra to allow clients to maintain settings in a user friendly way.
https://docs.modmore.com/en/Open_Source/ClientConfig/index.html
MIT License
28 stars 27 forks source link

#152 #167

Closed gerbenvandekraats closed 5 years ago

gerbenvandekraats commented 5 years ago

What does it do ?

Why is it needed ?

Media Source path is shown when empty.

Related issue(s)/PR(s)

See issue #152.

Mark-H commented 5 years ago

Please split up PRs in the future by feature/fix.

I don't understand why two very different things (a media source path being included for an empty value, and a new feature that makes a value come from a setting) are in the same PR and that's complicating things unnecessarily.

gerbenvandekraats commented 5 years ago

Good point. Will do in the future.