Context-Aware Dropdown Sort-Order

modmore / ClientConfig

ClientConfig is a MODX Revolution Extra to allow clients to maintain settings in a user friendly way.

https://docs.modmore.com/en/Open_Source/ClientConfig/index.html

MIT License

28 stars 27 forks source link

Context-Aware Dropdown Sort-Order #188

Closed sebastian-marinescu closed 1 year ago

sebastian-marinescu commented 2 years ago

Summary

Currently the context-dropdown doesn't acknowledge the sort-order (rank) of contexts.

Expected behavior

Display the contexts in the context-dropdown in their configured order/rank.

I'm going to take a look at it myself.

Mark-H commented 2 years ago

That extends the base context getlist processor so that's certainly interesting. Perhaps that doesn't handle the sort properly out of the box, or the client side is sending a different sortBy by default.

muzzwood commented 1 year ago

Yeah it looks like the core processor sets the default sort field as key rather than rank. So that would need to be overridden, or a sort param passed (there currently isn't one). I'll get this sorted (sorry! 😛 ) now.

muzzwood commented 1 year ago

Fixed in https://github.com/modmore/ClientConfig/commit/1eceff92a52f91bcabb791d76000d90670c90781