modmore / ClientConfig

ClientConfig is a MODX Revolution Extra to allow clients to maintain settings in a user friendly way.
https://docs.modmore.com/en/Open_Source/ClientConfig/index.html
MIT License
28 stars 27 forks source link

Radio settings #203

Open sebastian-marinescu opened 1 year ago

sebastian-marinescu commented 1 year ago

Adds support for radiogroup-settings. See #202 for details.

Resolves #202 But needs to wait for https://github.com/modxcms/revolution/pull/16404 to be accepted.

sebastian-marinescu commented 1 year ago

Sneak-Preview:

image

How it would be used:

image

Mark-H commented 10 months ago

This is cool. As far as that core fix goes, do we have to implement some kind of version check to prevent radiogroups from being used on <3.0.4?

sebastian-marinescu commented 10 months ago

Probably a good idea! And also we should do the same for the 2.x branch, when https://github.com/modxcms/revolution/pull/16467 is accepted.

That version-check would need to go into this if-clause: https://github.com/modmore/ClientConfig/blob/bd22b11d523d59b682259a05c5cc3798f986c5d2/assets/components/clientconfig/js/mgr/sections/home.js#L133

Correct?

Do you know, if we have the MODX-version information there available?