search

modmore / ClientConfig

ClientConfig is a MODX Revolution Extra to allow clients to maintain settings in a user friendly way.
https://docs.modmore.com/en/Open_Source/ClientConfig/index.html
MIT License
28 stars 27 forks source link

check if settings is set to a value to prevent cache corruption #213

Open Peeet93 opened 3 months ago

Peeet93 commented 3 months ago

What does it do ?

check if settings is set to a value to prevent cache corruption

Why is it needed ?

211

Related issue(s)/PR(s)

211

Mark-H commented 3 months ago

I'm not sure if I'm seeing how this helps - $settings is being set on line 82 so this is always going to run?

Wasn't #211 also about the lexicon cache, not the ClientConfig cache itself?

Feels like I'm missing something 😅

Peeet93 commented 2 months ago

I tested it with 2 Projects and after i removed this Check, it got corrupted in like a day. This was the point where the cache was set.