search

modmore / Gitify

Command line toolkit to make managing a MODX site in git a lot easier.
MIT License
122 stars 55 forks source link

Install packages doesn't work with MODX 2.4 #125

Closed renekopcem closed 9 years ago

renekopcem commented 9 years ago

I found out today that the Gitify install:package --all doesn't work with the latest MODX 2.4.

It returns:

Fatal error: Call to protected method modTransportProvider::getClient() from context 'modmore\Gitify\Command\InstallPackageCommand' in /Users/renekopcem/Gitify/src/Command/InstallPackageCommand.php on line 168

To replicate it:

packages:
    modx.com:
        service_url: 'http://rest.modx.com/extras/'
        description: 'The official MODX transport facility for 3rd party components.'
        packages:
            - ace
            - ckeditor
            - fastfield
            - formit
            - gatewaymanager
            - getcache
            - getresources
            - migx
            - pthumb
            - resizer
            - translit
            - versionx

Setup: OSX, latest Gitify, PHP 5.5.27

sonicpunk commented 9 years ago

I encountered this same issue!

graphiclunarkid commented 9 years ago

Same here. In fact gitify package:install doesn't work for me with a single package either. Same error message:

PHP Fatal error: Call to protected method modTransportProvider::getClient() from context 'modmore\Gitify\Command\InstallPackageCommand' in /usr/local/src/gitify/src/Command/InstallPackageCommand.php on line 168

My setup:

alroniks commented 9 years ago

I'll try fix it today.

Mark-H commented 9 years ago

Maybe this is something to fix in the core, technically it is a BC break so we could correct that for 2.4.1 as long as getClient still returns the same. Op 1 sep. 2015 7:12 AM schreef "Ivan Klimchuk" notifications@github.com:

I'll try fix it today.

— Reply to this email directly or view it on GitHub https://github.com/modmore/Gitify/issues/125#issuecomment-136588321.

Mark-H commented 9 years ago

Sent a pull request for fixing the core: https://github.com/modxcms/revolution/pull/12633

Assuming that gets merged into 2.4.1, that should fix the issue.

hansek commented 9 years ago

:+1:

renekopcem commented 9 years ago

I tested it with the new version of MODX 2.4.1 and it is working. So thank you!