modmore / Gitify

Command line toolkit to make managing a MODX site in git a lot easier.
MIT License
122 stars 55 forks source link

Extracted plugin file doesn't contain all properties #216

Open Kookabura opened 7 years ago

Kookabura commented 7 years ago

Summary

Quick summary what's this issue about. Extracted plugin file doesn't contain all properties. There is no disabled and static for example.

Step to reproduce

How to reproduce the issue, including custom code if needed. Plugins section config:

plugins:
        class: modPlugin
        primary: name
        extension: .php

Gitify extract

Observed behavior

How it behaved after following steps above.

id: 5
source: 1
name: miniShop2
category: miniShop2
properties: 'a:0:{}'
static_file: core/components/minishop2/elements/plugins/plugin.minishop2.php

Expected behavior

How it should behave after following steps above.

id: 5
source: 1
name: miniShop2
category: miniShop2
properties: 'a:0:{}'
disabled: 1
static: 0
static_file: core/components/minishop2/elements/plugins/plugin.minishop2.php

Environment

Gitify version, MODX version, Operating System, MySQL version, PHP version, etc. Gitify version 0.12.0, MODX version 2.4.2, 10.1.17-MariaDB, PHP 5.4.16

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/42406772-extracted-plugin-file-doesn-t-contain-all-properties?utm_campaign=plugin&utm_content=tracker%2F2783338&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2783338&utm_medium=issues&utm_source=github).
Mark-H commented 6 years ago

It only includes keys that are not set to the default value, that's probably what you're seeing.