Always unset content for static elements

modmore / Gitify

Command line toolkit to make managing a MODX site in git a lot easier.

MIT License

122 stars 55 forks source link

Always unset content for static elements #423

Closed rtripault closed 1 year ago

rtripault commented 1 year ago

What does it do ?

Always unset the "content" attribute on static elements, so that only the content added at the bottom is used

Why is it needed ?

We had issues where every extract the content attribute of a static template was either removed, or added back. Always removing the attribute felt like acceptable as the content is always populated from the bottom of the yaml file

muzzwood commented 1 year ago

Hi @rtripault thanks for the PR (and the others! 😄 ). I've so far been unable to replicate the issue you're describing, however since unsetting it here appears to cause no other issues, I'll go ahead with merging it. Do let us know if you discover there's any extra criteria needed to cause the issue, I'd be interested in seeing it. Cheers!