Closed livingroot closed 11 months ago
replaced SplFileInfo::getBasename() calls with SplFileInfo::getFilename()
gitify build
$file = new SplFileInfo("directory/файл.txt"); // file, which contains cyrillic characters var_dump($file->getBasename()); var_dump($file->getFilename());
output:
string(4) ".txt" // wrong string(12) "файл.txt" // correct
Related issue: https://github.com/modmore/Gitify/issues/188
Thanks for the PR, we'll test this and include it on the next release. 💙
This appears to work without issue. Thanks for your contribution @livingroot ! 😃
What does it do ?
replaced SplFileInfo::getBasename() calls with SplFileInfo::getFilename()
Why is it needed ?
gitify build
removed those files.Example:
output:
Related issue: https://github.com/modmore/Gitify/issues/188