modmore / QuickstartButtons

Component for managing Quickstart buttons on your MODX manager Dashboard.
5 stars 7 forks source link

Globally added CSS-rule i.icon messes with Search-Icon #35

Closed sebastian-marinescu closed 8 years ago

sebastian-marinescu commented 8 years ago

A globally added rule for i.icon adds a width of 16px.

i.icon {
    display: inline-block;
    width: 16px;
    height: 16px;
    background-size: 100%;
    background-repeat: no-repeat;
    background-position: left center;
}

It seems to be used for the configuration modal, but it messes up the search-icon when on the dashbard:

image

sebastian-marinescu commented 8 years ago

It also messes a little bit with the other icons in the header:

image becomes image

And the height messes a little with the tree-icons:

image > image

Although I like your line-height in the tree better, I don't think it should come from QSB. I have checked the icons of QSB in the dashboard-widget and in the CMP, both use .fa-icon.

Mark-H commented 8 years ago

Fixed in 1.3