Migrate script issue [MODX 3]

modmore / VersionX

Resource & Element Versioning Extra for MODX Revolution (supports 2.2 and up). Extends the core in a future-proof manner to keep copies of every change to resources, templates, template variables, chunks, snippets and plugins.

https://modmore.com/extras/versionx/

40 stars 20 forks source link

Migrate script issue [MODX 3] #123

Closed Jako closed 8 months ago

Jako commented 1 year ago

The migrate script seems to have issues.

PHP Fatal error: Uncaught TypeError: query(): Return value must be of type xPDOIterator, xPDO\xPDOIterator returned in /.../core/components/versionx/migrate.php:47

PHP 8.1, MODX 3.0.3

Mark-H commented 1 year ago

Removing the return type hint from that function should help. Looks like we've got some mixed 2.x/3.x logic in there that needs to be looked at...

Jako commented 1 year ago

Without the type hint the migration works fine.

muzzwood commented 8 months ago

Fixed in https://github.com/modmore/VersionX/commit/92f48a76af0d778164db459b911fca6741be3d71