modmore / VersionX

Resource & Element Versioning Extra for MODX Revolution (supports 2.2 and up). Extends the core in a future-proof manner to keep copies of every change to resources, templates, template variables, chunks, snippets and plugins.
https://modmore.com/extras/versionx/
40 stars 20 forks source link

Reload resource after revert #61

Closed SiarAneas closed 2 weeks ago

SiarAneas commented 11 years ago

Hi Mark! I'm having the following issue (checked it in several browsers - so I hope it isn't just me): When reverting to a previous version the resource isn't reloaded in manager so all fields have still the values from before the revert (though the revert was saved in background). If the user now clicks on the save button (which gets also enabled after the revert) the old data (from before the revert) is saved again.

Im using Revo 2.2.8 btw - not sure whether this is relevant for this issue. Cheers,

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27291095-reload-resource-after-revert?utm_campaign=plugin&utm_content=tracker%2F805489&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F805489&utm_medium=issues&utm_source=github).
SiarAneas commented 11 years ago

Can anyone confirm this behaviour or is this just me? Cheers!

Mark-H commented 10 years ago

I seemed to have missed this notification. It indeed doesn't refresh the page after a revert, but that shouldn't be too hard to add and I'll try to add that in the next release.

neoneddy commented 8 years ago

+1

sebastian-marinescu commented 6 years ago

+1

It's counter-intuitive, and also me and my editors forget about it every now and then.

sebastian-marinescu commented 6 years ago

Hi @Mark-H, I could look deeper into this, if you want. On the first quick look, I think adding it to the JS success-handler here https://github.com/Mark-H/VersionX2/blob/d575c893260f3e1112fbcb31c0d0e0877cdacee1/assets/components/versionx/js/mgr/resources/grid.resources.js#L119 could be a solution. Also the message should either be updated, or a second message could appear.

What do you think?

muzzwood commented 2 weeks ago

There is a full page reload for any kind of revert in VersionX 3.x Closing!