modmore / VersionX

Resource & Element Versioning Extra for MODX Revolution (supports 2.2 and up). Extends the core in a future-proof manner to keep copies of every change to resources, templates, template variables, chunks, snippets and plugins.
https://modmore.com/extras/versionx/
40 stars 20 forks source link

Resource form returns to Document tab on save. #74

Closed tehsquidge closed 5 years ago

tehsquidge commented 9 years ago

Hi,

I've noticed that after installing VersionX that when saving a Document the page returns to the Document tab. Without VersionX installed the user is not move from the tab they're currently on (for example the Template Variable tab). This is just a slight annoyance but it would be good to fix if possible.

I've tested this on a fresh install of MODX and the latest VersionX from the package manager.

thanks, Liam

Mark-H commented 9 years ago

I'd love to see this fixed as well, but to be honest I'm not exactly sure why this is happening. If anyone knows.. let me know.

Mark-H commented 8 years ago

Note to self: changing the way the tab is added by using Ext.override instead of tabpanel.add might do the trick. Though I'm not 100% sure that's the cause.

Mark-H commented 5 years ago

Fixed in 2.2.2. Turns out MODx.addTab() calls tabs.setActiveTab(0); and because the tab got added in a MODx.on('ready', callback); callback, that got executed repeatedly after a save.