search

modmore / docs

The official documentation for modmore extras and services. Contributions welcome!
https://docs.modmore.com/
3 stars 29 forks source link

Semantic Placeholder for Search Input #9

Open jpdevries opened 7 years ago

jpdevries commented 7 years ago

Took a swing at this but didn't get it to work design wise. <input placeholder> is meant to display an example of a valid value for the input like "Content Blocks". It is not meant to describe the input or prompt the user.

Mark-H commented 7 years ago

Looks like you did sorta get this done? Not sure if "Content Blocks" is a great placeholder though, that doesn't make much sense as a search term for 90% of the pages.

jpdevries commented 7 years ago

Oh I didn't mean to commit that change to the placeholder 

Get Outlook for iOS

On Thu, Oct 20, 2016 at 12:12 AM +0200, "Mark Hamstra" notifications@github.com wrote:

Looks like you did sorta get this done? Not sure if "Content Blocks" is a great placeholder though, that doesn't make much sense as a search term for 90% of the pages.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Mark-H commented 7 years ago

I've set the placeholder back to the "Search documentation" for now. There's still the hidden label you added, so is that sufficient do you think?

jpdevries commented 7 years ago

Technically no. The placeholder is meant to suggest a valid entry like "extras" or even just "documentation" but it is not meant to describe the input itself.

Not very high priority, but now it might be confusing and will read 'search documentation' twice to screen readers.

jpdevries commented 7 years ago

More on the float label pattern http://bradfrost.com/blog/post/float-label-pattern/