modmore / importX

Addon for MODX Revolution which will take your CSV Formatted files (or raw paste) and transforms it into resources. Funded by Working Party (digital agency based in Sydney, @workingparty)
http://www.markhamstra.com/
23 stars 17 forks source link

feedback for partial imports #42

Open christianhanvey opened 11 years ago

christianhanvey commented 11 years ago

Add some feedback to improve the user experience... When an import partially works, it would be nice to have some feedback on the resources that were imported. For example, when you get a message like: 'XXX' could not be imported because a resource with alias 'XXX' already exists its not immediately clear that some resources were imported, and some were not. I think it would be good to provide feedback here on which lines of the import were done, (or which were not - which is probably what the user cares more about).

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3309047-feedback-for-partial-imports?utm_campaign=plugin&utm_content=tracker%2F1511225&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1511225&utm_medium=issues&utm_source=github).
Mark-H commented 11 years ago

If an import fails it'll stop processing and dump info from the core on screen...if you encountered situation where it didnt thats a bug and will need more info on what failed.

christianhanvey commented 11 years ago

I've pasted the contents from the console log file below. I'm attempting to importing some resources I've already imported (because I know that will trigger the same error). It fails on the first item (because of duplicate alias) and stops. Is this what you are expecting?

So my original point was that the error message could be improved by telling the user which line to continue the import from.

/*

Attempted to set execution time to infinite. Max execution time currently: infinite.

Running pre-import tests on submitted data...

No errors in pre-import found. Preparing import values...

No errors found while checking the import values: 2 items found. Running import...

Error: uri: Resource 962 is already using the URI products/broadcast/radio-transmission/exciters/exciters-professional-series-ptxlcd/ptx100lcddsp.html. Please enter a unique alias or use Freeze URI to manually override it. alias: Resource 962 is already using the URI products/broadcast/radio-transmission/exciters/exciters-professional-series-ptxlcd/ptx100lcddsp.html. Please enter a unique alias or use Freeze URI to manually override it.

/* EOF */

Mark-H commented 11 years ago

Ah okay. Gotcha! Op 4 dec. 2012 02:53 schreef "Christian Hanvey" notifications@github.com het volgende:

I've pasted the contents from the console log file below. I'm attempting to importing some resources I've already imported (because I know that will trigger the same error). It fails on the first item (because of duplicate alias) and stops. Is this what you are expecting?

So my original point was that the error message could be improved by telling the user which line to continue the import from.

/*

Attempted to set execution time to infinite. Max execution time currently: infinite.

Running pre-import tests on submitted data...

No errors in pre-import found. Preparing import values...

No errors found while checking the import values: 2 items found. Running import...

Error: uri: Resource 962 is already using the URI products/broadcast/radio-transmission/exciters/exciters-professional-series-ptxlcd/ptx100lcddsp.html. Please enter a unique alias or use Freeze URI to manually override it. alias: Resource 962 is already using the URI products/broadcast/radio-transmission/exciters/exciters-professional-series-ptxlcd/ptx100lcddsp.html. Please enter a unique alias or use Freeze URI to manually override it.

/* EOF */

— Reply to this email directly or view it on GitHubhttps://github.com/Mark-H/importX/issues/42#issuecomment-10980947.

KirilOkun commented 10 years ago

Second this request. During an import i got the same issue of duplicate aliases. The error message also stated that 20 out of 171 records were imported by didn't say which ones. This is extremely unhelpful. It should list the details of the imported records so they can be removed from the next import after the aliases are fixed.