search

modmore / importX

Addon for MODX Revolution which will take your CSV Formatted files (or raw paste) and transforms it into resources. Funded by Working Party (digital agency based in Sydney, @workingparty)
http://www.markhamstra.com/
23 stars 17 forks source link

TV Values don't Update #48

Open jpdevries opened 11 years ago

jpdevries commented 11 years ago

When set to update mode tv values do not get updated.

Steps to reproduce on a fresh MODX install with ImportX installed (assumes a tv id of 1)

pagetitle;alias;isfolder;tv1 Analysing;analysing;1;importxtest

id;pagetitle;alias;isfolder;tv1 2;Analysing2;analysing;1;importxtest2

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5139741-tv-values-don-t-update?utm_campaign=plugin&utm_content=tracker%2F1511225&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1511225&utm_medium=issues&utm_source=github).
jpdevries commented 11 years ago

Been trying to track down this bug, seems like the place to look is startimport.php line 49 (where $modx->runProcessor is called for either create or update) and passes in a line element, created by csv.php

jpdevries commented 11 years ago

Verified that on update the $lines Array returned by prepareCsv->prepareCsv() contains the correct updated TV Values and that what is being passed to $modx->runProcessor in startimport.php is correct (updated TV value). For some reason the update processor isn't saving those TV values

jpdevries commented 11 years ago

Possibly related MODX bug: http://tracker.modx.com/issues/5965

adamwintle commented 9 years ago

Any know fix/hack for this?

KirilOkun commented 9 years ago

+1. This is an important feature to be able to update tvs in bulk. Any progress or workarounds for this?

Mark-H commented 9 years ago

Did the patch in #50 (i.e. v1.1.1) not do the trick? That's the only known "fix/hack" I know off, but if that doesn't work there's probably no other way to fix this other than a big refactor to stop reusing the core processors.

KirilOkun commented 9 years ago

Thanks Mark. Somehow i missed that one. Will give it a try.

All the best.

On 10/10/2014 01:36 AM, Mark Hamstra wrote:

Did the patch in #50 https://github.com/Mark-H/importX/pull/50 (i.e. v1.1.1) not do the trick? That's the only known "fix/hack" I know off, but if that doesn't work there's probably no other way to fix this other than a big refactor to stop reusing the core processors.

— Reply to this email directly or view it on GitHub https://github.com/Mark-H/importX/issues/48#issuecomment-58556255.