search

modmuss50 / OptiFabric

A fabric mod that patches optifine into the game at runtime.
https://www.curseforge.com/minecraft/mc-mods/optifabric
Mozilla Public License 2.0
172 stars 184 forks source link

OptiFine Internal Resources #156

Open JimStoneCraft opened 4 years ago

JimStoneCraft commented 4 years ago

Is there anyway to turn off the 'OptiFine Internal Resources' on the 'Select Resource Pack' screen.

It's overriding my texture pack with the OptiFine connected glass and sandstone textures, even if I put my pack at the top of the list some textures are still used from OptiFine.

JimStoneCraft commented 4 years ago

Found a way around it by putting some dummy fixed texture ctm in my resource packs for all the textures OptiFine adds (sandstone, red sandstone, bookshelf and glass panes).

Then put my resource pack at the top of the list (thus overriding the OptiFine textures).

modmuss50 commented 4 years ago

Humm, what texture pack is this? The internal resources are required for optifine to function correctally, putting texture packs above it shouldn’t cause an issue.

Bodnov commented 4 years ago

Hi, I have the same problem. Using a patched Flow's HD Texture pack. Strange is that the top block/row is ok by the sandstone and red sandstone.

modmuss50 commented 4 years ago

I can make it so the internal resources could be disabled, im not sure what effect that would have though.

modmuss50 commented 4 years ago

Beta 8 going out now with this change, please open another issue if you contitune to have issues.

JimStoneCraft commented 4 years ago

John Smith Legacy - www.johnsmithlegacy.co.uk

Resource packs stack, textures not in the top pack will be taken from the next pack down, OptiFine Internal Resources in this case.

OptiFine includes some ctm textures for glass, sandstone, red sandstone, bookshelf and block model fixes for glass panes.

So for example, if the resource pack at the top of the list doesn't have a sandstone ctm then it's used from the next pack down (OptiFine Internal Resources) thus displaying those vanilla textures (over-riding my JS resource pack).

Beta 8 fixes the issue for me but is another step to tell users to turn off the OptiFine Internal Resources pack when using the JS pack or some textures look wrong.

OptiFine on it's own only loads the included resource pack (OptiFine Internal Resources) stuff if no resource pack is loaded, is there a way of detecting and only loading it if no resource pack is loaded?

modmuss50 commented 4 years ago

Humm, ill have a look into it, I may need to get more creative with the way I fixed this. Atleast now its possible to use.

I will re open this issue, as it could do with more work.

Superplay64 commented 4 years ago

I'd like to add that I'm having same issue, even with Programmer Art.

2020-04-15_13 43 04