modmuss50 / mod-publish-plugin

A Gradle plugin to publish mods to a range of destinations
https://modmuss50.github.io/mod-publish-plugin/
MIT License
56 stars 9 forks source link

optional not actually uploading as optional #10

Closed SamsTheNerd closed 1 year ago

SamsTheNerd commented 1 year ago

optional dependencies show as required on modrinth and curseforge.

gradle setup here just for reference incase i have something set up wrong ?

publishMods {
    file = remapJar.archiveFile
    additionalFiles.from(sourcesJar.archiveFile)
    changelog = file("$rootDir/changelog.md").text
    type = STABLE
    modLoaders.add("fabric")
    modLoaders.add("quilt")

    version = project.version + "-fabric"
    displayName = "Hex Gloop" + " " + project.version + "[Fabric]"

    curseforge {
        accessToken = providers.environmentVariable("CURSEFORGE_API_KEY")
        projectId = "897558"
        minecraftVersions.add("1.19.2")
        requires {
            slug = "architectury-api"
        }
        requires {
            slug = "hexcasting"
        }
        requires {
            slug = "wnboi"
        }
    }

    modrinth {
        accessToken = providers.environmentVariable("MODRINTH_API_KEY")
        projectId = "ryfyOhoP"
        minecraftVersions.add("1.19.2")

        requires {
            // architectury api
            // id = "XV72M5Gg"
            slug = "architectury-api"
        }
        requires {
            slug = "hex-casting"
        }
        requires{
            // fabric api
            // id = "hfsU4hXq"
            slug = "fabric-api"
        }
        requires {
            slug = "wnboi"
        }
        optional{
            slug="trinkets"
        }
    }
}
modmuss50 commented 1 year ago

This is fixed by: https://github.com/modmuss50/mod-publish-plugin/pull/8

I have been busy with other things the past few days, ill resolve this ASAP 👍