modmuss50 / mod-publish-plugin

A Gradle plugin to publish mods to a range of destinations
https://modmuss50.github.io/mod-publish-plugin/
MIT License
50 stars 7 forks source link

Potential Fix for #12 #13

Closed ApexModder closed 11 months ago

ApexModder commented 11 months ago

Do not provide gameVersions if parentFileID for CurseForge uploads.

Fix CurseForge json encoder serializing nulls, CurseForge treats nulls as "provided" values, causing this whole issue (#11 & #12) with gameVersions.


As you can see in the below images with these changes applied, I was able to publish the plugin to local maven, include it in my mod and use it to publish to CurseForge with no problems.

### Image showing gradle finished with no errors ![image](https://github.com/modmuss50/mod-publish-plugin/assets/29412632/316d800c-855d-48b2-9cb6-6a39cca07674) ### Image showing file uploaded with `additionalFiles` ![image](https://github.com/modmuss50/mod-publish-plugin/assets/29412632/d84009fd-26ec-492d-b3ce-ad7147078fce)