modmuss50 / mod-publish-plugin

A Gradle plugin to publish mods to a range of destinations
https://modmuss50.github.io/mod-publish-plugin/
MIT License
50 stars 7 forks source link

fix `WALL_OF_SHAME` on modrinth #41

Closed AnAwesomGuy closed 3 weeks ago

AnAwesomGuy commented 4 months ago

that's all! :)

AnAwesomGuy commented 4 months ago

Looks good to me. Although, do you happen to have a list of what modrinth supports for it's game_version argument. I can't seem to find anything.

we iterate over Mojang's https://piston-meta.mojang.com/mc/game/version_manifest_v2.json in MinecraftApi, and get the versions from there. however, modrinth doesn't accept versions with spaces in their name, so this PR replaces the ones with spaces with the ones modrinth uses.