search

modnaut / primary

0 stars 0 forks source link

Why was the width attribute added to the XSL for filefield #29

Closed dannycohn closed 11 years ago

dannycohn commented 11 years ago

I'm a bit confused about commit f3516a4. Why did you add that to the XSL? The width attribute is handled by the root item template in ViewMetaData.xsl. Was it not working?

modnaut commented 11 years ago

It was working but I didn't like the size of the text field - too small. There may be times where it will be necessary to change the size based on the layout. Additionally, I wanted to see how clear and easy it was to get into the xsl and add something in myself. It was pretty easy.... good job on the organization and cleanliness!

dannycohn commented 11 years ago

But the width is already output by the root item XSL, this would produce redundant output and is confusing.

Thanks, I'm blushing from your compliment :-)

modnaut commented 11 years ago

Ok, then how is it done correctly? I want the ability to change the size of the textbox on this element.

dannycohn commented 11 years ago

You can just set the width on the filefield element. The root XSL handles this, we don't need it in the filefield XSL also.

image image

modnaut commented 11 years ago

Ok, got it, I will take out the change. Thanks.

modnaut commented 11 years ago

Code removed. Please verify everything looks ok. Thanks.