modo-studio / SugarRecord

CoreData/Realm sweet wrapper written in Swift
MIT License
2.11k stars 223 forks source link

Change access modifier of NSManagedObject.entityName class var extens… #331

Closed LuizZak closed 7 years ago

LuizZak commented 7 years ago

…ion to allow overriding in clients of the library

Related issue: Link

Short description

Change NSManagedObject.entityName class var from public to open to allow clients of the library to alter the property entity name, if necessary.

Sometimes, providing a class name that differs from the entity's name in .xcdatamodeld is needed to avoid clashes with existing symbols in code. Allowing overriding of this property permits adapting such changes to SugarRecord, as well.

Solution

Describe the solution you came up with and the reasons that led you to that solution. If you thought about other solutions don't forget about mentioning them.

Implementation

GIF

Relevant: me furiously coding the seemingly endless diff for this change. No PoweGloves survived in the making of this PR.

pepicrft commented 7 years ago

hahah very good gif. Thanks for the improvement.