search

modoboa / modoboa-dmarc

A set of tools to use DMARC through Modoboa.
MIT License
15 stars 11 forks source link

32 no traceback on failed #33

Closed kryskool closed 6 years ago

kryskool commented 6 years ago

If attachment is incorrect, don't send traceback and proper return code (like 65 ) see http://www.postfix.org/pipe.8.html and https://gist.github.com/bojanrajkovic/831993#file-sysexits-h-L101

ref #32

codecov[bot] commented 6 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.47%. The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   84.57%   85.05%   +0.47%     
==========================================
  Files          18       18              
  Lines         415      435      +20     
==========================================
+ Hits          351      370      +19     
- Misses         64       65       +1
Impacted Files Coverage Δ
modoboa_dmarc/lib.py 80% <100%> (+1.42%) :arrow_up:
modoboa_dmarc/tests/test_management_command.py 100% <100%> (ø) :arrow_up:
modoboa_dmarc/tests/mixins.py 93.93% <91.66%> (-1.52%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74773ed...ef429ea. Read the comment docs.

kryskool commented 6 years ago

Test on Python 2.7 does not retrun the same exception Test on Python 3.5 fail because pip not found

kryskool commented 6 years ago

IOError become OsError in Python 3.3

kryskool commented 6 years ago

@tonioo it's done, thanks for the review