Open fbfeix opened 10 months ago
Attention: 12 lines
in your changes are missing coverage. Please review.
Comparison is base (
4a2e9f2
) 54.40% compared to head (5aae454
) 53.73%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of the issue/feature this PR addresses: The
_setup_venv
method in the existing codebase has been experiencing intermittent SSL connection issues when attempting to download a file usingwget
. This problem has been causing the method to fail occasionally, preventing the successful setup of a virtual environment. Additionally, the method assumes the downloaded archive will be located in a certain directory without verifying the file's existence, leading to potential errors during the unzipping process.Current behavior before PR:
_setup_venv
method useswget
to download a file, but if an SSL connection issue occurs, the method fails without retrying the download.Desired behavior after PR is merged:
download_remote_file
has been introduced to handle file downloads, with the capability to retry the download a specified number of times in case of failures, mitigating the impact of intermittent SSL connection issues._setup_venv
method now utilizes thedownload_remote_file
method to handle the file download, ensuring that the file exists before proceeding to unzip it.download_remote_file
method ensures the target directory exists or creates it if necessary, and returns the absolute path of the downloaded file, providing more robust file handling and aiding in troubleshooting if issues arise in the future.